Add links to now playing popup #3700
Conversation
yayuyokitano
added
core
| if (!artist) { | ||
| return ''; | ||
| } | ||
| return `https://www.last.fm/music/${encodeURIComponent(artist)}`; |
There was a problem hiding this comment.
I'm guessing we don't need to handle localisation here as lastfm should redirect?
There was a problem hiding this comment.
ah thats a good spot actually. No lastfm does not redirect.
There was a problem hiding this comment.
Looking at v2 - it seems web scrobbler never localized urls.
Since the main purpose here is to restore functionality i think localization of URLs should be a separate PR.
Did some simplification regardless, and fixed one pretty huge bug i found that i introduced in #3671 that caused applying an edit to not actually exit the edit state.
|
Also just to make it clear, album and album artist are not grabbed from metadata because it is unreliable method of getting link for those fields. Track and artist are reliable. |
|
Reverted the link change – reverting this allows us to change the baseurl based on localization more easily later |
Adds links to the now playing popup for track, artist, album, album artist, playcount (leading to track in users library).
Also does a bit of general split up of the now playing component.