Make options page more responsive, improve building #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayuyokitano
added
core
inverse
approved these changes
May 9, 2023
| @@ -40,20 +40,32 @@ async function main() { | |||
| ]; | |||
| await Promise.all(scripts); | |||
|
|
|||
| if (isDev() && releaseTarget === 'safari') { | |||
| await new Promise((resolve) => { | |||
There was a problem hiding this comment.
Why do we need to have this sleep?
There was a problem hiding this comment.
The dev build does not await the completion of the build before continuing, the sleep allows the initial build processes to finish up before creating the xcode project.
There is probably a better way here long term, but this did nicely for development on my end for the time being.
There was a problem hiding this comment.
Ahhh is that because of the watch mode? Yeah we should probably think of a better way longer term - but right now it'll do :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a bottom context menu in place of sidebar on low widths for better experience. Still not 100% ideal but pretty close.
Example:
Also adds a dev mode to safari build.
Also adds new build target as discussed.