Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally render different options in safari #3757

Merged
merged 3 commits into from May 26, 2023

Conversation

yayuyokitano
Copy link
Member

Hopefully a decent compromise with apple's policies.
Release ready with this merge methinks.

Introduces ifdef to the repo, and an extension to highlight them.
It is worth noting that the conditional compile plugin used is quite small and potentially unstable, but has worked just fine for me https://github.com/KeJunMao/vite-plugin-conditional-compile

@yayuyokitano yayuyokitano added core This issue or pull request is related to the extension core new-feature For PRs that add new functionality labels May 25, 2023
@yayuyokitano yayuyokitano requested a review from inverse May 26, 2023 13:24
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest fan of this as it adds conditional behaviour which will be harder to dev with but I see your reasoning :)

Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest fan of this as it adds conditional behaviour which will be harder to dev with but I see your reasoning :)

Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest fan of this as it adds conditional behaviour which will be harder to dev with but I see your reasoning :)

@yayuyokitano yayuyokitano merged commit b798dcc into web-scrobbler:master May 26, 2023
8 checks passed
@yayuyokitano yayuyokitano deleted the conditional branch May 28, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue or pull request is related to the extension core new-feature For PRs that add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants