Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timer #3804

Merged
merged 2 commits into from
May 28, 2023
Merged

Fix timer #3804

merged 2 commits into from
May 28, 2023

Conversation

yayuyokitano
Copy link
Member

Resets the timer properly.
Closes #3799 Closes #3802
linter had some fun with this file, but only meaningful change (should be) the reset() function, the rest should just be spacing stuff

@yayuyokitano yayuyokitano added core This issue or pull request is related to the extension core fixed labels May 28, 2023
inverse
inverse requested changes May 28, 2023
View reviewed changes
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I guess we could revert #3752 as it's covered with yours :)

@yayuyokitano yayuyokitano merged commit 3b2e286 into web-scrobbler:master May 28, 2023
8 checks passed
@yayuyokitano yayuyokitano deleted the timer branch May 28, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inverse inverse inverse approved these changes

Assignees
No one assigned
Labels
core This issue or pull request is related to the extension core
Projects
None yet
Milestone
No milestone
2 participants
@yayuyokitano @inverse