Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull new translations #3860

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Pull new translations #3860

merged 1 commit into from
Jun 6, 2023

Conversation

inverse
Copy link
Member

@inverse inverse commented Jun 4, 2023

Describe the changes you made

I noticed we were not pulling down new translations so I ran tx pull --all

Looks like some are not translated, but that shouldn't impact current flow as I see.

Additional context

@inverse inverse added the patch-change For patch changes label Jun 4, 2023
yayuyokitano
yayuyokitano approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@yayuyokitano yayuyokitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does increase bundle size a fair bit, but doesn't impact the size of any of the JS files, so it shouldn't be able to impact performance in any way

@inverse inverse merged commit baef990 into web-scrobbler:master Jun 6, 2023
8 of 9 checks passed
@inverse inverse deleted the pull-translations branch June 6, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yayuyokitano yayuyokitano yayuyokitano approved these changes

Assignees
No one assigned
Labels
patch-change For patch changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inverse @yayuyokitano