Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector for Radio Carpice (radcap.ru) #3972

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

projecteurlumiere
Copy link
Contributor

Describe the changes you made
Add a connector for Radio Caprice (radcap or http://radcap.ru).

Additional context
I had some doubts about the label naming:

  • RADio CAPrice (RADCAP) is the title on their main page,
  • but their app's title is Caprice Radio,
  • and throughout their website and on many radio aggregators, it is simply Radio Caprice.

I opted for the last one because it seemed more widespread.

Other than that, that is my first PR ever - I hope I got everything correctly.

@inverse inverse added new-feature For PRs that add new functionality minor-change For minor changes labels Jul 18, 2023
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the mobile interaction for play/pause - looks like a nice site for discovering genres :)

src/connectors/radcap.ts Show resolved Hide resolved
@inverse inverse merged commit d611ad6 into web-scrobbler:master Jul 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-change For minor changes new-feature For PRs that add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants