Add NTS Shows connector #4480
Merged
Add NTS Shows connector #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l over the site, extending list of URLs
yayuyokitano
added
new-feature
yayuyokitano
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you made
This adds support for scrobbling (for premium users who have access to tracklistings) for NTS Radio's collection of archived shows.
Additional context
I manually specify all NTS URLs except for
*nts.live/live-tracklist/*as this is used for live radio scrobbling. Is there a more concise way to express this?Currently, player selector is a wrapper containing the player bar and the live tracklist. I am not sure if this is the correct approach as the progress bar / time / moving waverform next to the current playing track seems to trigger a state change very frequently. Is this a bad thing or not? I am not sure if the player should somehow just be the play / pause button and the current playing track name, or if all these updates are inconsequential? I.e. in the below, when playing, state changes are triggered all the time, but not when paused as nothing is moving then.