fix: ship less files to address TSC issues #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users have been running into issues caused by shipping the tsconfig.json in the package.
|
Ping @Gozala :) How can we help you get this merged/released? |
|
Hmm... since using web standards is a core foundation of Remix, perhaps it would be best to fork this and include it directly in Remix core. Doesn't seem like a lot of activity on a critical dependency. |
Closed
|
Merged thanks for taking time to look into this and providing a fix. |
This was referenced Jan 28, 2022
Gozala
added a commit
that referenced
this pull request
Jan 28, 2022
Addresses regression introduced by #35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have been running into issues caused by shipping the tsconfig.json in the package.