Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsEqualChecker and CallableChecker #462

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Add IsEqualChecker and CallableChecker #462

merged 3 commits into from
Jun 6, 2023

Conversation

danielburger1337
Copy link
Contributor

Q A
Branch? 3.2
Bug fix? no
New feature? yes (Changelog.md doesnt exist)
Deprecations? no
Tickets None
License MIT

I find myself recreating these checkers in pretty much all of my applications.

The IsEqualChecker checks if the header/claim value EXACTLY matches the given value.
The CallableChecker passes the header/claim value to the callable and checks that the return is TRUE.

@danielburger1337
Copy link
Contributor Author

Well, that was kinda stupid on my part.

I didnt see a php-cs-fixer config and even checked if its a dependecy and was dumbfounded when it wasnt.
I have never even heard of the "symplify/easy-coding-standard" tool.

I probably should've checked the .github/workflows before submitting the PR.

Anyway, its fixed now!

@danielburger1337
Copy link
Contributor Author

danielburger1337 commented Jun 6, 2023

Static Analysis failures are unrelated to this PR

@Spomky Spomky self-assigned this Jun 6, 2023
@Spomky Spomky added this to the 3.3.0 milestone Jun 6, 2023
@Spomky Spomky merged commit b346ddd into web-token:3.2.x Jun 6, 2023
8 of 9 checks passed
@Spomky
Copy link
Member

Spomky commented Jun 6, 2023

Many thanks.
No worries on the failing CI/CD; I will take time to fix it all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants