Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AsCommand attributes for commands #532

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

temp
Copy link
Contributor

@temp temp commented Feb 28, 2024

Target branch: 3.3x
Resolves issue -

  • It is a Bug fix
  • It is a New feature
  • It is related to dependencies

Includes:

  • Breaks BC
  • Deprecations

Three commands were missing the import for the AsCommand attribute:

The command defined in "Jose\Component\Console\NoneKeyGeneratorCommand" cannot have an empty name.
The command defined in "Jose\Component\Console\PublicKeyCommand" cannot have an empty name.
The command defined in "Jose\Component\Console\X5ULoaderCommand" cannot have an empty name.

@temp
Copy link
Contributor Author

temp commented Feb 28, 2024

Since I don't have signed commits (yet), maybe you can simply transfer this to a new commit?

@Spomky Spomky merged commit 1dbef13 into web-token:3.3.x Feb 28, 2024
12 checks passed
@Spomky Spomky added this to the 3.3.1 milestone Feb 28, 2024
@Spomky Spomky added the bug label Feb 28, 2024
@Spomky
Copy link
Member

Spomky commented Feb 28, 2024

Many thanks!

@temp
Copy link
Contributor Author

temp commented Feb 28, 2024

That was quick, thank you!

@temp temp deleted the fix/ascommand branch February 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants