Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CheckerManager::getCheckers #92

Merged
merged 2 commits into from Feb 27, 2018
Merged

Test CheckerManager::getCheckers #92

merged 2 commits into from Feb 27, 2018

Conversation

timrourke
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #...
License MIT
Tests added yes
Doc PR no

This pull request adds a simple unit test to verify the happy path for CheckerManager::getCheckers.

@coveralls
Copy link

coveralls commented Feb 25, 2018 •
edited

Coverage Status

Coverage increased (+0.02%) to 85.755% when pulling b0fdb34 on timrourke:feature/add-get-checkers-test into 7ad838e on web-token:master.

@timrourke
Copy link
Contributor Author

@Spomky What's the story with the failing Scrutinizer failure here? Looks unrelated to my proposed changes, not familiar with this tool.

@Spomky Spomky changed the base branch from master to v1.1 February 27, 2018 08:04
@Spomky
Copy link
Member

Spomky commented Feb 27, 2018

Thanks.
No worries about Scrutinizer, this will be fixed soon.

@Spomky Spomky merged commit c7d2187 into web-token:v1.1 Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timrourke @coveralls @Spomky