Fix get in pydal.helpers.classes Reference class calling __getattr__ …

[emman27]

…with 3 variables instead of 2 as per signature

[mdipierro]

Can you explain the rationale for this change?

[emman27]

@mdipierro if you look at the method signature:
def __getattr__(self, key):.
However, the current code calling this method is
return self.__getattr__(key, default)
Since self is automatically prepended onto the method call, this raises a TypeError.
The code for __getattr__ is in fact fine and does not handle the default case,, whereas for get which was changed in this PR, the default case is incorrectly passed on instead of directly handled

[mdipierro]

I think a better solution than is to add a default option to

base.py:    def __getattr__(self, key): to __getattr__(self, key, default=None)
objects.py:    def __getattr__(self, k): to __getattr__(self, k, default=None)

because help(getattr) allows of a default option. Also we do not want to get the default is the attribute is defined and its value is 0 or ''.

If I agree, may I ask you to make this change? else I can do it.

[emman27]

You're right on that count. However I think the fix that needs to be made is in line 216 (onwards) of https://github.com/web2py/pydal/blob/master/pydal/helpers/classes.py, where it should read, letting the underlying default be handled by the get method in objects.py which already works fine in handling defaults in the case of KeyErrors (I am assuming here that self._record refers to a Row object, correct me if I am wrong)

def __getattr__(self, key, default=None): # Change made here to include default in method signature
        if key == 'id':
            return long(self)
        if key in self._table:
            self.__allocate()
        if self._record:
            # to deal with case self.update_record()
            return self._record.get(key, default) # Change made here to switch None to default
        else:
            return None

If this is okay with you I can make the changes

[mdipierro]

Yes. Please make the change. I will also change all the other getattr for uniformity.

[codecov-io]

Codecov Report

Merging #465 into master will increase coverage by 0.13%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   69.43%   69.57%   +0.13%     
==========================================
  Files          69       67       -2     
  Lines        9253     9202      -51     
  Branches     2001     2000       -1     
==========================================
- Hits         6425     6402      -23     
+ Misses       2305     2297       -8     
+ Partials      523      503      -20