Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2.5 #798

Closed
ilvalle opened this issue Feb 18, 2015 · 17 comments
Closed

Drop python 2.5 #798

ilvalle opened this issue Feb 18, 2015 · 17 comments

Comments

@ilvalle
Copy link
Contributor

ilvalle commented Feb 18, 2015

The last security bug fix release (source only) of python 2.5 has been publish in 2011.
https://www.python.org/download/releases/2.5.6/
There are no tests on travis-ci for python 2.5.

@leonelcamara
Copy link
Collaborator

I really support this, there are a ton of features that 2.5 simply does not have.

@jklundell
Copy link

I notice that two of the web2py setup scripts explicitly reference 2.5.

@niphlod
Copy link
Member

niphlod commented Feb 18, 2015

+1 on dropping. setup scripts are often unmaintained but we can ditch them in case those can't be "upgraded" to use at least 2.6. Last time I pushed for dropping 2.5 I was told "someone will test the code for 2.5" but frankly it's a PITA having it around.

@ilvalle
Copy link
Contributor Author

ilvalle commented Feb 19, 2015

@niphlod has surely a better view of what to do, as far as I can see dropping python 2.5 means:

  • update scripts as mentioned by @jklundell
  • remove unnecessary crontrib (ex: simplejson)
  • remove unnecessary try-except (if any)

@niphlod
Copy link
Member

niphlod commented Feb 19, 2015

we can simply start by just saying we drop it, and then search through the code for specific thingies (as https://github.com/web2py/web2py/blob/master/gluon/widget.py#L43). Once we face it, we strip it. if the travis-ci works, then we're good.

@gi0baro
Copy link
Member

gi0baro commented Feb 26, 2015

+1 for dropping too.

@niphlod
Copy link
Member

niphlod commented Mar 5, 2015

let's hear what @mdipierro thinks about it. At this point it's more a "political" choice than a matter of operational actions to do on the core code.

@mdipierro
Copy link
Contributor

Not quite ready for this
On Mar 5, 2015 2:21 PM, "niphlod" notifications@github.com wrote:

let's hear what @mdipierro https://github.com/mdipierro thinks about
it. At this point it's more a "political" choice than a matter of
operational actions to do on the core code.


Reply to this email directly or view it on GitHub
#798 (comment).

@niphlod
Copy link
Member

niphlod commented Mar 7, 2015

who's asking for 2.5 ?

@mdipierro
Copy link
Contributor

let’s ask.

On Mar 7, 2015, at 1:15 PM, niphlod notifications@github.com wrote:

who's asking for 2.5 ?


Reply to this email directly or view it on GitHub.

@mdipierro
Copy link
Contributor

I asked. But why dropping it? What are the pros?

On Mar 7, 2015, at 1:15 PM, niphlod notifications@github.com wrote:

who's asking for 2.5 ?


Reply to this email directly or view it on GitHub.

@leonelcamara
Copy link
Collaborator

Well, one is that we could drop a few modules that we include like simplejson since they're available in later versions.

@niphlod
Copy link
Member

niphlod commented Mar 8, 2015

just for starters, right now I'm not sure web2py works with 2.5 in all of its features.
There are tons of places in code that can be simplified, and tons of things that can be implemented without thinking to backport something just for the sake of 2.5 compatibility.

@gi0baro
Copy link
Member

gi0baro commented Mar 8, 2015

+1 on @niphlod

@mdipierro
Copy link
Contributor

OK. I agree we can drop 2.5

On Sun, Mar 8, 2015 at 8:43 AM, Giovanni Barillari <notifications@github.com

wrote:

+1 on @niphlod https://github.com/niphlod


Reply to this email directly or view it on GitHub
#798 (comment).

@mdipierro
Copy link
Contributor

This is not a bug. I close it. It is agreed anyway.

@lablua
Copy link

lablua commented Apr 1, 2015

I can confirm web2py already fails to work on Python 2.5.2. Syntax error in gluon/sqlhtml.py. (On line 1822 in Version 2.9.12-stable+timestamp.2015.01.17.06.11.03)

Could you please update web2py.com to no longer list 2.5 as a supported version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants