Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use custom domain linkdex.dag.haus #4

Merged
merged 4 commits into from Sep 8, 2022
Merged

feat: use custom domain linkdex.dag.haus #4

merged 4 commits into from Sep 8, 2022

Conversation

olizilla
Copy link
Contributor

@olizilla olizilla commented Sep 7, 2022

prod lives at linkdex.dag.haus
staging is at staging.linkdex.dag.haus

...all non-prod stages follow that pattern ${stage}.linkdex.dag.haus

License: MIT
Signed-off-by: Oli Evans oli@protocol.ai

prod lives at `linkdex.dag.haus`
staging is at `staging.linkdex.dag.haus`

...all non-prod stages follow that pattern `${stage}.linkdex.dag.haus`

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@olizilla
Copy link
Contributor Author

olizilla commented Sep 7, 2022

linkdex.dag.haus is updated in cloud flare to use route53 nameservers

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@seed-deploy seed-deploy bot temporarily deployed to pr4 September 7, 2022 21:08 Inactive
@seed-deploy
Copy link

seed-deploy bot commented Sep 7, 2022

View stack outputs

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@seed-deploy
Copy link

seed-deploy bot commented Sep 7, 2022

Stack outputs updated

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. For consistency with all other projects I would go with linkdex-staging like we do for api-staging.*, ipfs-staging.*, and so on

@olizilla
Copy link
Contributor Author

olizilla commented Sep 8, 2022

@vasco-santos good point! Alas, that would be difficult to implement here as the dag.haus domain is managed on cloudflare not route53. The trick that makes this work at all is the subdomain linkdex.dag.haus is manually delegated to route53 name servers. I could special case staging and delegate both linkdex.dag.haus and linkdex-staging.dag.haus but I prefer the look of ${stage}.linkdex.dag.haus and the original reason for the api-staging pattern was that it was hard to generate all the necessary SSL certificates for sub-sub-domains, which isn't the case here.

stacks/LinkdexStack.ts Outdated Show resolved Hide resolved
remove the hardcoded customDomain so it can be configured for environments that need it.

License: MIT
Signed-off-by: Oli Evans <oli@protocol.ai>
@seed-deploy seed-deploy bot temporarily deployed to pr4 September 8, 2022 15:03 Inactive
@olizilla olizilla merged commit a34b1a3 into main Sep 8, 2022
@olizilla olizilla deleted the domain branch September 8, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants