feat: improved origins filtering #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - switch to an sqs lib that polls for new messages concurrently rather than in batches - rewrite pickup worker so we can compose it out of single-responsibilty pieces instead of having to pass through the giant config ball. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
test the api is available when start is called. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
fixes #101 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
2 mins is still timeout after node restarts License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
- grab p2p addrs from origins if we can. - limit origins to 10, just so we dont accept unboundedly long origins lists License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
|
@olizilla mind rebasing this before review please? 🙏🏼 Most of this diff is already in #main and makes quite difficult to review changes |
|
Sorry! done! note, i'd encourage merging from main rather than rebase these days as:...
|
vasco-santos
approved these changes
Mar 16, 2023
| return input | ||
| .split(',') | ||
| .filter(isMultiaddr) | ||
| .filter(hasPublicIpAddress) |
There was a problem hiding this comment.
No more usage of this function. Looks like we can remove it
| import { findUsableMultiaddrs } from '../basic/helper/multiaddr.js' | ||
|
|
||
| const fixture = [ | ||
| '/ip4/127.0.0.1/tcp/4001/p2p/12D3KooWADjHf2kyANQodg9z5sSdX4bGEMbWg7ojwu6SCyDAMtzN', |
There was a problem hiding this comment.
Could we add a dns4 address just to make sure everything is working as expected for non hasBogonIpAddress?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubo provides it's own multiaddrs as origins on pin service requests when it has the blocks for a pin request locally. This PR aims to filter out unusable multiaddrs early, and make a best effort to convert them into something we can connect to.
License: MIT