feat: did prinicipal #149
Merged
feat: did prinicipal #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
reviewed
Nov 30, 2022
gobengo
reviewed
Nov 30, 2022
| */ | ||
| async resolveAndVerify(payload, signature) { | ||
| try { | ||
| const key = await this.resolve() |
There was a problem hiding this comment.
What if Principal id is a non-key DID that resolves to more than one key?
There was a problem hiding this comment.
We’ll update this once we start supporting multiple keys, right now we don’t so we keep it simple
|
|
||
| export const code = 0x1300 | ||
| export const name = Verifier.name | ||
|
|
||
| /** @type {'EdDSA'} */ |
There was a problem hiding this comment.
This type assertion could be helpfully moved into Verifier.signatureAlgorithm (or in there you could use a /** @type {const} */ when assigning the eddsa string
gobengo
approved these changes
Dec 1, 2022
Gozala
added a commit
that referenced
this pull request
Dec 1, 2022
- add .withDID method to principals for wrapping keys in DIDs - 💣 🚨 change output of .toArchive .from to support multikey signers
Gozala
added a commit
that referenced
this pull request
Dec 1, 2022
- add .withDID method to principals for wrapping keys in DIDs - 💣 🚨 change output of .toArchive .from to support multikey signers
Merged
This was referenced Dec 1, 2022
Closed
Merged
6 tasks
gobengo
added a commit
to storacha/w3up
that referenced
this pull request
Dec 7, 2022
…#246) Motivation: * second attempt at this #238 * after first was reverted #245 Warning: * the versions of ucanto we're upgrading to were backward-incompatible. storacha/ucanto#149 * Old 'SignerArchive' exports will probably no longer import using the new `@ucanto/principal@^4.0.0` `SignerArchive` * in slack, @alanshaw said he thinks this is unlikely to cause problems: "There’s no code in production that uses toArchive" Blockers * [x] Wait for these two to land first (@hugomrdias says so) * [x] @hugomrdias #207 * [x] @alanshaw #228 * [x] then will need to resolve merge conflicts on this branch * [x] @gobengo resolve conflicts after #207 * [x] @gobengo resolve conflicts after #228 Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
gobengo
added a commit
to storacha/w3up
that referenced
this pull request
Apr 11, 2023
…#246) Motivation: * second attempt at this #238 * after first was reverted #245 Warning: * the versions of ucanto we're upgrading to were backward-incompatible. storacha/ucanto#149 * Old 'SignerArchive' exports will probably no longer import using the new `@ucanto/principal@^4.0.0` `SignerArchive` * in slack, @alanshaw said he thinks this is unlikely to cause problems: "There’s no code in production that uses toArchive" Blockers * [x] Wait for these two to land first (@hugomrdias says so) * [x] @hugomrdias #207 * [x] @alanshaw #228 * [x] then will need to resolve merge conflicts on this branch * [x] @gobengo resolve conflicts after #207 * [x] @gobengo resolve conflicts after #228 Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
This was referenced Apr 11, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes #139 to arbitrary DIDs and supersedes it. It also changes following things
.withDIDmethod is added so you could wrap did:key (or other) into e.g.did:dnsordid:web.{ id: DID, keys: Record<DID<'key'>, CryptoKey|Uint8Array> }keysit will only have one key, however it addresses feat: did:dns support #139 (comment) and provides a way to have multiple keys in the futureFixes #137