feat!: move space register email parameter to an --email option and add --provider option
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're only authorized to act as a single account we shouldn't need to pass an email address to `space register` since we can infer which one to use from the delegations we currently have. Preserve the ability to pass email for cases where we are authorized as multiple accounts.
this will allow us to register spaces with NFT.storage
travis
changed the title
space register optionalspace register optional and add --provider option
gobengo
reviewed
Mar 22, 2023
gobengo
reviewed
Mar 22, 2023
alanshaw
approved these changes
Mar 22, 2023
|
could do with tests... |
Yep agreed - I didn't see any existing tests for this so wanted to get this up before I go down that rabbithole, but will look at writing tests for this now... |
travis
changed the title
space register optional and add --provider optionspace register to an --email option and add --provider option
travis
changed the title
space register to an --email option and add --provider optionspace register to an --email option and add --provider option
travis
changed the title
space register to an --email option and add --provider optionspace register email parameter to an --email option and add --provider option
|
ok I've opened an issue for testing after digging in a bit - we need to figure out how to test this and other commands that depend on remote services: #61 |
olizilla
pushed a commit
that referenced
this pull request
Mar 23, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.2.2...v2.0.0) (2023-03-23) ### ⚠ BREAKING CHANGES * upgrade to latest access & upload clients ([#64](#64)) * move `space register` email parameter to an `--email` option and add `--provider` option ([#60](#60)) * use new account model ([#53](#53)) ### Features * move `space register` email parameter to an `--email` option and add `--provider` option ([#60](#60)) ([c1ed0e5](c1ed0e5)) * show help text if no cmd ([#63](#63)) ([fd5f342](fd5f342)) * update README with new ToS ([#62](#62)) ([4ce61d7](4ce61d7)), closes [#54](#54) * upgrade to latest access & upload clients ([#64](#64)) ([b5851ca](b5851ca)) * use new account model ([#53](#53)) ([7f63286](7f63286)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're only authorized to act as a single account we shouldn't need to pass an email address to
space registersince we can infer which one to use from the delegations we currently have.Preserve the ability to pass email using the
--emailoption for cases where we are authorized as multiple accounts.Also add a
--provideroption tospace registerto allow users to register spaces with other providers like NFT.Storage.