fix!: drop filecoin storefront skip submit queue option #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: not possible to skip submit queue on storefront service anymore
alanshaw
approved these changes
Apr 19, 2024
vasco-santos
deleted the
fix/drop-filecoin-storefront-skip-submit-queue-option
branch
vasco-santos
pushed a commit
that referenced
this pull request
Apr 23, 2024
🤖 I have created a release *beep* *boop* --- ## [5.0.0](filecoin-api-v4.6.1...filecoin-api-v5.0.0) (2024-04-23) ### ⚠ BREAKING CHANGES * not possible to skip submit queue on storefront service anymore ### Fixes * drop filecoin storefront skip submit queue option ([#1371](#1371)) ([1114383](1114383)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vasco-santos
added a commit
to storacha/w3infra
that referenced
this pull request
Apr 24, 2024
We just need to update `upload-api` dep storacha/w3up#1387 and get `AllocationsStorage` implementation to implement `remove`. All tests run as part of the interface tests imported from https://github.com/web3-storage/w3up/blob/main/packages/upload-api/test/handlers/blob.js Also note that `filecoin-api` was updated (internally to `upload-api` and the options for filecoin storefront skip submit queue were removed, therefore storacha/w3up#1371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed since #1332 got released and used in w3infra storacha/w3infra#343 and has been deployed in production without issues for the last few weeks
BREAKING CHANGE: not possible to skip submit queue on storefront service anymore