Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked/multipart upload presentation feedback #1140

Closed
orvn opened this issue Mar 21, 2022 · 4 comments · Fixed by #1261
Closed

Chunked/multipart upload presentation feedback #1140

orvn opened this issue Mar 21, 2022 · 4 comments · Fixed by #1261
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up stack/website time-sinkhole

Comments

@orvn
Copy link
Contributor

orvn commented Mar 21, 2022

Recently, when uploading a file, the UI started giving less feedback on the percentage uploaded.

  • In the case of small files, the upload appears to jump suddenly, from 0% to 100%
  • When uploading a larger file, the user can see that pieces of it are being uploaded, but the progress feedback seems interspersed and sporadic

0-multi-upload-prod-w3s-site-03-03

@orvn orvn added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Mar 21, 2022
@orvn
Copy link
Contributor Author

orvn commented Mar 21, 2022

multi-uploader-new-fe.mp4
  • On the new site design, this even looks like the upload might be hanging

  • Note the progress feedback on last file (which is larger than the others)

  • Implemented a stopgap

    • The ellipses are now animated on the new site design, providing visual feedback to the user that something is happening (they animate from one, to two, to three dots)
    • ......

@orvn
Copy link
Contributor Author

orvn commented Mar 28, 2022

@dchoi27 I can solve this visually with some presentation layer delays and timeouts, but I'm not sure why this behavior appeared all of a sudden from the API/infra layers?

@dchoi27
Copy link
Contributor

dchoi27 commented Mar 28, 2022

hm - so one thing that @alanshaw mentioned is that the progress just comes from the client's knowledge of how many chunks of the upload got uploaded. so it's not an API/infra thing, but just that the JS client after it's converted a file to a CAR and chunked it up into 100MB chunks knows how many of these chunks got uploaded. he also said that nothing's really changed to that end.

in the video you recorded with the new website, how large was the ezgif file?

@orvn
Copy link
Contributor Author

orvn commented Mar 28, 2022

The ezgif file is 270 KiB (it's actually the gif at the top of this issue), but the other file is a few hundred MiB.

Backburner sounds good. In the mean time we can figure out what a visual solution might look like.

@dchoi27 dchoi27 added P2 Medium: Good to have, but can wait until someone steps up time-sinkhole and removed need/triage Needs initial labeling and prioritization labels Mar 30, 2022
@orvn orvn linked a pull request Apr 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up stack/website time-sinkhole
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants