-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CID links in files table #1243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! one point is that since things are wrapped in directories by default, it might be better to detect whether a file was uploaded with wrapWithDirectory: true
and if so, have the link include the path to the file. but not sure if that's simple to detect - if not we can just merge.
No you can't detect that from the CID alone. You'd need to download the block, decode it, inspect the entries, if only one then link to that item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't easily do anything smarter than link to the CID on a gateway today, so let's get this PR merged so we at least have that link in the UI.
Just need to use dweb.link instead of ipfs.io and this is good to go
packages/website/components/account/filesManager/fileRowItem.js
Outdated
Show resolved
Hide resolved
i'm gonna get this merged and deployed. (it feels like an important affordance for the UI and a small code change) |
Closes #1164 and #1175