Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to the content? #1164

Closed
aronchick opened this issue Mar 24, 2022 · 2 comments · Fixed by #1243
Closed

Link to the content? #1164

aronchick opened this issue Mar 24, 2022 · 2 comments · Fixed by #1243
Assignees
@orvn
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up stack/website

Comments

@aronchick
Copy link

aronchick commented Mar 24, 2022 •
edited by dchoi27
Loading

@dchoi27 edit for clarity: Currently, in the /account page of the website, the user's files table shows the CIDs of the file, but there are no links to actually viewing the content through a gateway.

Can we make the text in either the file name or CID column a link to ipfs.io/ipfs/{cid} for the given row?

cc @orvn

Is there a link to my stored content? I feel like i'm missing it :(
@aronchick aronchick added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization labels Mar 24, 2022
@dchoi27 dchoi27 added P1 High: Likely tackled by core team if no one steps up kind/bug A bug in existing code (including security flaws) stack/website and removed need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature labels Mar 25, 2022
@orvn
Copy link
Contributor

orvn commented Mar 25, 2022

(Adding this as P1)

@dchoi27
Copy link
Contributor

dchoi27 commented Apr 6, 2022

@orvn any updates here? #1175 asking for the same thing

@dchoi27 dchoi27 mentioned this issue Apr 6, 2022
Closed
@orvn orvn mentioned this issue Apr 12, 2022
Merged
olizilla pushed a commit that referenced this issue Apr 26, 2022
@orvn
feat: CID links in files table (#1243)
dccf457 
- CIDs that appear in the files table are now linked to a gateway URL
- All links open in a new tab

Closes #1164 and #1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orvn orvn

Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up stack/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: CID links in files table web3-storage/web3.storage
3 participants
@aronchick @orvn @dchoi27