Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upload progress feedback #1261

Merged
merged 16 commits into from
May 16, 2022
Merged

feat: Upload progress feedback #1261

merged 16 commits into from
May 16, 2022

Conversation

svvimming
Copy link
Contributor

Animated count upward between chunked points in file upload progress. This count is displayed in the file uploader component next to uploading files to visually indicate to the user that the file is indeed uploading and not hanging.

@svvimming svvimming requested a review from orvn April 19, 2022 17:35
@svvimming svvimming self-assigned this Apr 19, 2022
@svvimming svvimming changed the title (WIP) feat: Upload progress feedback feat: Upload progress feedback (WIP) Apr 19, 2022
@svvimming
Copy link
Contributor Author

The upload progress percentage has been pulled out into its own component called 'UploadProgress' found in the dropzone directory in the zero module. The dropzone calls in this component to handle two things:

  1. updating the percentage value at a set frame rate (currently 1 fps)
  2. calculating a crude upload rate by looking at the interval of time and progress between upload chunks. The component then uses this upload rate to change the amount by which the progress percentage is incremented during animation.

@svvimming svvimming changed the title feat: Upload progress feedback (WIP) feat: Upload progress feedback Apr 20, 2022
@orvn orvn linked an issue Apr 25, 2022 that may be closed by this pull request
@orvn orvn merged commit 3392a06 into main May 16, 2022
@orvn orvn deleted the feat-upload-progress-feedback branch May 16, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chunked/multipart upload presentation feedback
2 participants