feat: enterprise let's chat form #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a styling conflict with the kwes-form default styling. There doesn't seem to be a way to turn it off easily in kwes-form either. Maybe @cmunns can help point me in the right direction? |
|
@heyjay44 can you take a look at this and let me know if this is close enough? |
|
Talked in the sync meeting. I'm going to fix it. |
|
Lookin good! (@drewdelano I think I saw when you demoed yesterday and it is way better now!)
|
gobengo
requested changes
Oct 18, 2022
There was a problem hiding this comment.
99% there. @drewdelano will you
- add jsdocs to the enterpriseTierRequestForm
- remove the unused kwSubmitted form handler (attached to id in a way that might be a footgun if someone else uses it later)
other things like the whitespace stuff are just fyi.
packages/website/components/enterpriseTierRequestModal/enterpriseTierRequestModal.js
Outdated
Show resolved
Hide resolved
packages/website/components/enterpriseTierRequestModal/enterpriseTierRequestModal.js
Show resolved
Hide resolved
packages/website/components/enterpriseTierRequestModal/enterpriseTierRequestModal.js
Outdated
Show resolved
Hide resolved
gobengo
approved these changes
Oct 18, 2022
gobengo
pushed a commit
that referenced
this pull request
Oct 19, 2022
🤖 I have created a release *beep* *boop* --- ## [2.29.0](website-v2.28.0...website-v2.29.0) (2022-10-18) ### Features * enterprise let's chat form ([#2034](#2034)) ([ec2bb57](ec2bb57)) * show tier modal on account page after logging in ([#2048](#2048)) ([1204561](1204561)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/Custom-Plan-let-s-chat-enterprise-form-58358bd0f51a489089b8c15a798bf2df