feat: show tier modal on account page after logging in #2048
Conversation
| @@ -2,6 +2,7 @@ | |||
| * @fileoverview Account Payment Settings | |||
| */ | |||
|
|
|||
| import { parse as queryParse } from 'querystring'; | |||
There was a problem hiding this comment.
I think this will bundle in a browser polyfill of this thing from nodejs stdlib. wdyt of using the DOM URLSearchParams constructor? https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/URLSearchParams
There was a problem hiding this comment.
@gobengo i checked and it looks like we're already bundling it. i can follow up with a tech debt PR if you want to refactor all locations in the codebase to use URL.
| @@ -187,6 +197,9 @@ const PaymentSettingsPage = props => { | |||
| onClose={() => { | |||
| setIsPaymentPlanModalOpen(false); | |||
| setHasAcceptedTerms(false); | |||
| if (planQueryParam) { | |||
| history.pushState({}, '', window.location.href.replace(/plan=[^&]+&?/, '')); | |||
There was a problem hiding this comment.
Is this inteded to wipe the query param?
If so, I think it's kinda nice to keep it around. That way the user can share the URL to that tier to themselves or others (e.g. via user-agent share functionality, copy url bar and paste elsewhere, etc)
Just curious, what is the motivation of the pushState and, if I'm reading it right, clearing the query param? If it's not strictly needed we might as well not do it.
There was a problem hiding this comment.
so, if the user closes the modal, it's their intention not to see it again. if they refresh the browser after closing the modal and then see the modal again, i figured it would be a little annoying. if they click the browser back button they'll see the modal and query param again with my current implementation. lmk what you want.
There was a problem hiding this comment.
ah, it's onclose. Nice. Sry for missing that.
There was a problem hiding this comment.
if they click the browser back button they'll see the modal and query param again with my current implementation.
awesome
jsdevel
force-pushed
the
feat-show-desired-plan-from-home-page
branch
from
7eab298
to
13ff0a2
Compare
| @@ -45,19 +46,36 @@ import GeneralPageData from '../../content/pages/general.json'; | |||
| * @property {PaymentMethodCard} card | |||
| */ | |||
|
|
|||
| function removePlanQueryParam() { | |||
There was a problem hiding this comment.
love how the function name is self-documenting 🙏
This shows the user the plan they wanted from the home page after logging in.
jsdevel
force-pushed
the
feat-show-desired-plan-from-home-page
branch
from
13ff0a2
to
072a5f5
Compare
yea, pushed up some changes to make the build pass. fingers crossed... |
🤖 I have created a release *beep* *boop* --- ## [2.29.0](website-v2.28.0...website-v2.29.0) (2022-10-18) ### Features * enterprise let's chat form ([#2034](#2034)) ([ec2bb57](ec2bb57)) * show tier modal on account page after logging in ([#2048](#2048)) ([1204561](1204561)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This shows the user the plan they wanted from the home page after logging in.