Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AddPaymentMethodForm shows a more end-user-friendly error message when it encounters an error #2058

Merged
merged 1 commit into from Oct 20, 2022
Merged

feat: AddPaymentMethodForm shows a more end-user-friendly error message when it encounters an error #2058

merged 1 commit into from Oct 20, 2022

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Oct 20, 2022 •
edited

Motivation:

How:

  • If the AddPaymentForm encounters an error, it doesn't render the error message (that is probably more intended for a developer to debug than the end-user), it renders in the html a message that gives the user an affordance to get in touch with us if the error keeps happening, and doesn't show any dev details. Dev details still appear in the dev console to aid debugging.

@gobengo gobengo marked this pull request as ready for review October 20, 2022 14:10
@gobengo gobengo changed the title AddPaymentMethodForm shows a more end-user-friendly error message when it encounters an error feat: AddPaymentMethodForm shows a more end-user-friendly error message when it encounters an error Oct 20, 2022
@github-actions
Copy link
Contributor

Website preview 🔗✨

build log

yusefnapora
yusefnapora approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gobengo gobengo merged commit 376e05b into main Oct 20, 2022
@gobengo gobengo deleted the 1666274428-addpayment-errormsg branch October 20, 2022 15:38
@github-actions github-actions bot mentioned this pull request Oct 20, 2022
Merged
@gobengo gobengo mentioned this pull request Oct 20, 2022
Open
gobengo pushed a commit that referenced this pull request Oct 23, 2022
@github-actions
chore(main): release website 2.31.0 (#2059)
caa45f7 
🤖 I have created a release *beep* *boop*
---


##
[2.31.0](website-v2.30.0...website-v2.31.0)
(2022-10-23)


### Features

* AddPaymentMethodForm shows a more end-user-friendly error message when
it encounters an error
([#2058](#2058))
([376e05b](376e05b))
* log terms of service acceptance
([#2028](#2028))
([47c3540](47c3540))


### Bug Fixes

* clarity on web3.storage PSA
([#2062](#2062))
([62dadb1](62dadb1))
* properly center align the loading icon within login/logout button
([#2043](#2043))
([4fa8ec3](4fa8ec3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdelano drewdelano drewdelano left review comments

@yusefnapora yusefnapora yusefnapora approved these changes

@e-schneid e-schneid Awaiting requested review from e-schneid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gobengo @yusefnapora @drewdelano