Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly center align the loading icon within login/logout button #2043

Conversation

e-schneid
Copy link
Contributor

@e-schneid e-schneid commented Oct 17, 2022

Closes #2002

Context: center aligns the loading icon within login/logout button

@github-actions
Copy link
Contributor

Copy link
Contributor

@gobengo gobengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of the context exactly but I can see how this might fix a bug

@e-schneid e-schneid merged commit 4fa8ec3 into main Oct 21, 2022
@e-schneid e-schneid deleted the 2002-log-in-log-out-button-loading-icon-is-not-centered-horizontally-or-vertically branch October 21, 2022 15:40
gobengo pushed a commit that referenced this pull request Oct 23, 2022
🤖 I have created a release *beep* *boop*
---


##
[2.31.0](website-v2.30.0...website-v2.31.0)
(2022-10-23)


### Features

* AddPaymentMethodForm shows a more end-user-friendly error message when
it encounters an error
([#2058](#2058))
([376e05b](376e05b))
* log terms of service acceptance
([#2028](#2028))
([47c3540](47c3540))


### Bug Fixes

* clarity on web3.storage PSA
([#2062](#2062))
([62dadb1](62dadb1))
* properly center align the loading icon within login/logout button
([#2043](#2043))
([4fa8ec3](4fa8ec3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Log in" / "Log out" button loading icon is not centered horizontally or vertically
3 participants