Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages/api should release with env vars NEXT_PUBLIC_W3UP_LAUNCH_ #2327

Closed
1 task done
gobengo opened this issue Nov 13, 2023 · 1 comment
Closed
1 task done

packages/api should release with env vars NEXT_PUBLIC_W3UP_LAUNCH_ #2327

gobengo opened this issue Nov 13, 2023 · 1 comment
Assignees
@gobengo
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization

Comments

@gobengo
Copy link
Contributor

gobengo commented Nov 13, 2023 •
edited
Loading

Motivation

Expectations

  • when this repo releases to staging the env vars from the staging gh env starting with NEXT_PUBLIC_W3UP_LAUNCH_ should be set in the resulting cloudflare func env

Tasks
Beta Give feedback
  1. ci: .github/workflows/api.yml when using wrangler-action passes with vars #2328
    gobengo
@gobengo gobengo added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization labels Nov 13, 2023
@gobengo gobengo mentioned this issue Nov 13, 2023
Merged
gobengo added a commit that referenced this issue Nov 13, 2023
@gobengo
ci: .github/workflows/api.yml when using wrangler-action passes with …
d8b07c8 
…vars (#2328)

…vars so that the env vars like NEXT_PUBLIC_W3UP_LAUNCH_ get added to cf
worker vars

Motivation:
* #2327
* tldr fix so that gh env vars get released with packages/api to
staging/production environments on cloudflare
@gobengo
Copy link
Contributor Author

gobengo commented Nov 13, 2023

this works now and I verified by testing the staging deployment behaves like the env var is set in the api

@gobengo gobengo closed this as completed Nov 13, 2023
@gobengo gobengo self-assigned this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gobengo gobengo

Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gobengo