Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post-ship website fixes and enhancements #1150

Merged
merged 6 commits into from
Apr 4, 2022

Conversation

orvn
Copy link
Contributor

@orvn orvn commented Mar 21, 2022

Various fixes and enhancements for the new website, which was shipped to production last week.
Most are edge-case or visual bug related.

  • Overflow of non-breaking file names
  • Docs footer contact area being condensed to one column on mobile
  • When a file is recently uploaded, it SP field appears as null
  • Re-add Countly tracking on 404 page
  • Add the error dialog to token deletion

* fix: add countly to 404 page

* feat: delete modal for token page

* feat: delete modal for token page

* fix: grid conflicts on docs footer

* fix: null on storage provider
@orvn orvn marked this pull request as ready for review March 28, 2022 03:55
@orvn orvn requested a review from alanshaw March 28, 2022 03:55
@dchoi27 dchoi27 requested a review from olizilla March 28, 2022 14:49
@orvn
Copy link
Contributor Author

orvn commented Mar 28, 2022

Closes #1131, #1127, #1146

@orvn orvn requested a review from dchoi27 March 28, 2022 18:29
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks suggested

  • send 404 path to countly as suggested by @gobengo
  • revert change to package-lock.json
  • review issue Small account page snags in new UI #1127 - the word break is fixed but the vertical space in the feature boxes remains. It may be intentional that the text is bottom aligned in their but please comment either way.

Screenshot 2022-03-31 at 14 48 34

Otherwise, no need to block on further reviews for this PR... merge when ready.

packages/website/pages/404.js Outdated Show resolved Hide resolved
@orvn
Copy link
Contributor Author

orvn commented Mar 31, 2022

Minor tweaks suggested

* send 404 path to countly as suggested by @gobengo

* revert change to package-lock.json

* review issue #1127 - the word break is fixed but the vertical space in the feature boxes remains. It may be intentional that the text is bottom aligned in their but please comment either way.

Otherwise, no need to block on further reviews for this PR... merge when ready.

Sounds good!

  • Making those changes
  • The asymmetric vertical alignment was indeed intentional, I'm good to change it if there are strong feelings that it appears out of place though. Will comment on the original issue Small account page snags in new UI #1127.

@orvn orvn requested review from gobengo and olizilla April 4, 2022 14:45
@orvn orvn merged commit 80be326 into main Apr 4, 2022
@orvn orvn deleted the feat/website-post-ship-fixes-enhancements branch April 4, 2022 14:46
This was linked to issues Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs footer issue on mobile Small account page snags in new UI
4 participants