Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pinned/uploaded storage bar feedback #1288

Merged
merged 5 commits into from
May 16, 2022
Merged

Conversation

svvimming
Copy link
Contributor

The storage bar in the storage manager section of the app UI has been split into different colours corresponding to uploaded and pinned files. There is also an accompanying legend.

@svvimming svvimming requested a review from orvn April 30, 2022 11:53
@svvimming svvimming self-assigned this Apr 30, 2022
@svvimming svvimming linked an issue Apr 30, 2022 that may be closed by this pull request
@svvimming svvimming marked this pull request as draft April 30, 2022 11:59
@svvimming svvimming marked this pull request as ready for review April 30, 2022 12:55
Copy link
Contributor

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svvimming just one condition to add: if either the stored or pinned files is zero, we can hide the legend item referring to it.

Copy link
Contributor

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good now 👍

@orvn orvn merged commit d47962d into main May 16, 2022
@orvn orvn deleted the feat-pinned-uploaded-storage branch May 16, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show both stored and pinned tables in app UI Storage bar not filling in the redesigned account page
2 participants