chore: fix pagination in the files page #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could fetch 26 and then still show a nice round 25 in the UI... |
|
I might be missing something - in the UI i thought I counted 25? I think what was happening is you show the button when theres 25 items, but the button doesn't take you anywhere (so its disabled). |
jnthnvctr
approved these changes
Jul 26, 2021
It does show 25 now, I changed the variable to be |
alanshaw
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like I cheated the system, but I'm fetching 25 items and only showing 24 in the UI, and only if we have 25+ items left, it shows the "next"
Related to #178