-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add blog link with navigation fix #1960
Conversation
@@ -10,6 +10,10 @@ | |||
background-size: cover; | |||
word-break: break-word; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This style at line 11 word-break: break-word;
was causing the issue with the nav on the docs page.
@@ -10,6 +10,10 @@ | |||
background-size: cover; | |||
word-break: break-word; | |||
|
|||
#navigation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CSS targets the navigation element setting the word-break to normal / no break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked on desktop and mobile (logged in and out state). The issue on docs page causing the line breaks on nav items does not occur. Issue appears resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
🤖 I have created a release *beep* *boop* --- ## [2.21.2](website-v2.21.1...website-v2.21.2) (2022-09-28) ### Bug Fixes * add blog link with navigation fix ([#1960](#1960)) ([efaed67](efaed67)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR adds a link to the new blog and addresses a formatting issue in the docs navigation