fix: this param for fetch calls #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Status | Count |
|---|---|
| 1 | |
| 27 |
Click to toggle table visibility
| Name | Status | Previous | Current |
|---|---|---|---|
brotli-size |
0.1.0 | - | |
bundlesize |
0.18.1 | - | |
caller-callsite |
2.0.0 | - | |
caller-path |
2.0.0 | - | |
ci-env |
1.17.0 | - | |
content-type |
1.0.4 | 1.0.5 | |
decompress-response |
4.2.1 | - | |
detect-libc |
1.0.3 | - | |
duplexer |
0.1.2 | - | |
expand-template |
2.0.3 | - | |
github-build |
1.2.3 | - | |
github-from-package |
0.0.0 | - | |
gzip-size |
4.1.0 | - | |
iltorb |
2.4.5 | - | |
is-directory |
0.3.1 | - | |
mimic-response |
2.1.0 | - | |
mkdirp-classic |
0.5.3 | - | |
napi-build-utils |
1.0.2 | - | |
node-abi |
2.30.1 | - | |
noop-logger |
0.1.1 | - | |
prebuild-install |
5.3.6 | - | |
prettycli |
1.4.3 | - | |
simple-concat |
1.0.1 | - | |
simple-get |
3.1.0 | - | |
tar-fs |
2.1.1 | - | |
tar-stream |
2.2.0 | - | |
tunnel-agent |
0.6.0 | - | |
which-pm-runs |
1.0.0 | - |
alanshaw
commented
Jul 19, 2023
| @@ -53,7 +53,7 @@ | |||
| "@rollup/plugin-json": "^4.1.0", | |||
| "@rollup/plugin-node-resolve": "^13.1.3", | |||
| "@types/mocha": "9.0.0", | |||
| "bundlesize": "^0.18.1", | |||
| "body-parser": "^1.20.2", | |||
There was a problem hiding this comment.
...was a missing dependency
alanshaw
commented
Jul 19, 2023
| headers = { ...headers, 'X-Name': encodeURIComponent(name) } | ||
| const headers = { | ||
| ...Web3Storage.headers(token), | ||
| 'Content-Type': 'application/vnd.ipld.car', |
There was a problem hiding this comment.
Ensures we always get a Content-Type header even when we do the Node.js fix below.
There was a problem hiding this comment.
FYI: I have created ipld/js-car#142 that we could reference official mime type, instead of having to copy that string all over.
alanshaw
commented
Jul 19, 2023
| "test:all": "run-s test:web test:cjs test:esm test:size", | ||
| "test:size": "bundlesize", | ||
| "test:all": "run-s test:web test:cjs test:esm", | ||
| "test:size": "npx bundlesize", |
There was a problem hiding this comment.
npx so that npm install in ndoe.js 20 doesn't fail because native module can't be compiled.
vasco-santos
approved these changes
Jul 19, 2023
Gozala
approved these changes
Jul 19, 2023
This was referenced Jul 19, 2023
alanshaw
added a commit
to nftstorage/nft.storage
that referenced
this pull request
Jul 20, 2023
alanshaw
pushed a commit
that referenced
this pull request
Jul 31, 2023
🤖 I have created a release *beep* *boop* --- ## [7.19.0](api-v7.18.1...api-v7.19.0) (2023-07-31) ### Features * write content claims ([#2291](#2291)) ([6a31c9b](6a31c9b)) ### Bug Fixes * remove unnecessary compatibility flags ([#2301](#2301)) ([436cdb8](436cdb8)) * signer DID ([82c3462](82c3462)) * this param for fetch calls ([#2292](#2292)) ([bf32c53](bf32c53)) * use error message value in cause ([9b07288](9b07288)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@web-std/fetchtov4with fix forthisparamArrayBufferasfetchbody instead of aBlob127.0.0.1instead oflocalhostso node doesn't auto resolve a IPv6 address and fail to connectnpm testtasks since it cannot be run on node.js 20 (depends on unmaintained native moduleiltorbwhich does not compile on node.js 20)resolves #2274