Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /account/payment disables changing plans after scheduled sunset date #2321

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Nov 9, 2023

Motivation:

Notes

  • it takes effect when rendering after the date configured by NEXT_PUBLIC_W3UP_LAUNCH_SUNSET_START, which is also the date that is used inside the announcement banner. We can easily change the exact logic in the shouldPreventPlanSwitching in w3up-launch.js later too
  • I got sick of looking at a React warning in browser console about invalid nesting of div inside p, and it was because payment page Tooltip (div) was in a p, so I made the Tooltip element name configurable to get rid of the warning. seems to work ok

Copy link
Contributor

github-actions bot commented Nov 9, 2023

@gobengo gobengo merged commit 22799fe into main Nov 9, 2023
7 checks passed
@gobengo gobengo deleted the gh-23-rm-changeplan branch November 9, 2023 23:58
gobengo pushed a commit that referenced this pull request Nov 13, 2023
🤖 I have created a release *beep* *boop*
---


##
[2.38.0](website-v2.37.0...website-v2.38.0)
(2023-11-13)


### Features

* /account/payment disables changing plans after scheduled sunset date
([#2321](#2321))
([22799fe](22799fe))
* can disable new user registration at /user/login API around w3up
launch by setting `NEXT_PUBLIC_W3UP_LAUNCH_LIMITED_AVAILABILITY_START`
([#2324](#2324))
([09a59c6](09a59c6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants