Merge pull request #2556 from ethereum/issue/2554

EventOptions interface types updated
web3 · Mar 22, 2019 · 0cb5562 · 0cb5562
2 parents 2cfff78 + 17e5ba6
commit 0cb5562
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/web3-eth-contract/types/index.d.ts b/packages/web3-eth-contract/types/index.d.ts
@@ -103,7 +103,7 @@ export interface ContractOptions {
 }
 
 export interface EventOptions {
-    filter: {};
+    filter?: {};
     fromBlock?: number;
     toBlock?: string | number;
     topics?: any[];

diff --git a/packages/web3-eth-contract/types/tests/contract-test.ts b/packages/web3-eth-contract/types/tests/contract-test.ts
@@ -49,6 +49,9 @@ contract.getPastEvents('MyEvent', {
     toBlock: 'latest'
 });
 
+// $ExpectType Promise<EventData[]>
+contract.getPastEvents('MyEvent', {});
+
 // $ExpectType Promise<EventData[]>
 contract.getPastEvents('MyEvent', {
     filter: {myIndexedParam: [20,23], myOtherIndexedParam: '0x123456789...'},