Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] sendTransaction not timing out as expected #1252

Closed
connectdotz opened this issue Dec 24, 2017 · 2 comments
Closed

[1.0] sendTransaction not timing out as expected #1252

connectdotz opened this issue Dec 24, 2017 · 2 comments
Assignees
Labels
Bug Addressing a bug
Projects

Comments

@connectdotz
Copy link

used web3.js 1.0.0-beta.26 with Parity 1.8.4.

Sent a not-signable transaction via websocket provider interface, expecting it to time out after x blocks read, but didn't happen...

parity showed it received the request, but never responded, and web3 never timeout...

After digging further realized the startWatching is only invoked in _confirmTransaction, which only called after the provider responded the initial sendTransaction(), which parity never did... While there might be a parity problem that it should have responded something, nevertheless, web3 should be able to act properly by timing out after x blocks as startWatching intended...

Can startWatching start prior to provider's initial response?

@nivida nivida self-assigned this Aug 9, 2018
@nivida nivida added the Bug Addressing a bug label Nov 29, 2018
@nivida nivida added this to To do in 1.0 Nov 29, 2018
@nivida
Copy link
Contributor

nivida commented Jan 22, 2019

This should be fixed within the next release. (PR #2000)

@nivida
Copy link
Contributor

nivida commented Mar 20, 2019

This got fixed with the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
No open projects
1.0
  
Done
Development

No branches or pull requests

2 participants