Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthereumProvider and the related refactoring #2000

Merged
merged 1,091 commits into from
Jan 25, 2019
Merged

EthereumProvider and the related refactoring #2000

merged 1,091 commits into from
Jan 25, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 15, 2018 •
edited
Loading

  • Port Web3 to es6.
  • Refactor the architecture to more SOLID & clean code.
  • Improve provider handling (Web3 should use internally always the same interface).
  • Each RPC method should be implemented once.
  • Method calls should be delegated with the JS Proxy object instead of adding them on construction.
  • Create AbstractWeb3Module class and remove core.packageInit().
  • Simplify the internal subscription handling.
  • Improve the documentation.
  • Fix the log subscription.
  • Write unit tests with Jest and move them to the related module folders.
  • defaultBlock, defaultAccount, timeoutBlock and confirmationBlock should be configurable for each module over the constructor.
  • Refactor ENS module (dependency inversion and not injection, EIP 1577)
  • Set up rollup for each module
  • Set up eslint & prettier
  • Update travis CI
  • Improve web3-utils & web3-core-helpers exports

@nivida nivida requested a review from frozeman October 15, 2018 16:12
frozeman
frozeman reviewed Oct 15, 2018
View reviewed changes
gulpfile.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/web3-bzz/src/index.js Outdated Show resolved Hide resolved
packages/web3-core-helpers/src/formatters.js Outdated Show resolved Hide resolved
packages/web3-core-helpers/src/formatters.js Outdated Show resolved Hide resolved
packages/web3-core-method/README.md Outdated Show resolved Hide resolved
@web3 web3 deleted a comment from frozeman Oct 17, 2018
@nivida nivida changed the title EthereumProvider EthereumProvider and the related refactoring Oct 18, 2018
@nivida nivida added this to the 1.0 milestone Oct 19, 2018
This was referenced Oct 25, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@nivida nivida mentioned this pull request Nov 20, 2018
Closed
12 tasks
@nivida nivida mentioned this pull request Nov 28, 2018
Closed
@nivida nivida added this to In progress in 1.0 Nov 28, 2018
This was referenced Nov 28, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@nivida nivida mentioned this pull request Jan 25, 2019
Closed
@nivida nivida merged commit 5998517 into 1.0 Jan 25, 2019
1.0 automation moved this from In progress to Done Jan 25, 2019
@filips123
Copy link
Contributor

@nivida This PR is now merged. When will new release be published?

@riccardopersiani riccardopersiani mentioned this pull request Jan 25, 2019
Closed
@levino
Copy link
Contributor

levino commented Jan 25, 2019 •
edited
Loading

OMG. I has been merged!! :)

@filips123 filips123 mentioned this pull request Jan 28, 2019
Closed
@nivida nivida deleted the ethereumProvider branch January 28, 2019 09:15
@neocybereth neocybereth mentioned this pull request Feb 6, 2019
Closed
@EddieOne
Copy link

How do we use these features?

@wbt wbt mentioned this pull request Jul 3, 2019
Open
@web3 web3 deleted a comment from wbt Aug 7, 2019
@gabmontes gabmontes mentioned this pull request Oct 7, 2019
Merged
@nivida nivida mentioned this pull request Feb 6, 2020
Closed
@cgewecke cgewecke mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nivida @filips123 @levino @coveralls @EddieOne @frozeman @joshstevens19 @aalok05 @Keith-CY