Personal ECRecover validates sig as address

[LayneHaber]

Expected behavior

Using eth.personal.ecRecover, it should return an address when provided with signed data. noticed it was checking the signed data as an input address.

Actual behavior

The function seems to be verifying the signed data as an address

function EcRecoverMethod(utils, formatters) {
      _classCallCheck(this, EcRecoverMethod);

      return _possibleConstructorReturn(this, _getPrototypeOf(EcRecoverMethod).call(this, 'personal_ecRecover', 3, utils, formatters));
    }

    _createClass(EcRecoverMethod, [{
      key: "beforeExecution",
      value: function beforeExecution(moduleInstance) {
        this.parameters[0] = this.formatters.inputSignFormatter(this.parameters[0]);
        this.parameters[1] = this.formatters.inputAddressFormatter(this.parameters[1]);
      }
    }]);

Steps to reproduce the behavior

1. Sign some data const sig = await web3.eth.personal.sign(data)
2. Try to recover your address const addr = await web3.eth.personal.ecRecover(data, sig)

Error Logs

function EcRecoverMethod(utils, formatters) {
      _classCallCheck(this, EcRecoverMethod);

      return _possibleConstructorReturn(this, _getPrototypeOf(EcRecoverMethod).call(this, 'personal_ecRecover', 3, utils, formatters));
    }

    _createClass(EcRecoverMethod, [{
      key: "beforeExecution",
      value: function beforeExecution(moduleInstance) {
        this.parameters[0] = this.formatters.inputSignFormatter(this.parameters[0]);
        this.parameters[1] = this.formatters.inputAddressFormatter(this.parameters[1]);
      }
    }]);

Versions

Mac OS, Node 11.3, web3 version beta-46

[nivida]

Thanks for submitting this issue! I will fix and release it asap.