Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting web3.eth.getChainId() #2534

Closed
nivida opened this issue Mar 20, 2019 · 0 comments
Closed

Documenting web3.eth.getChainId() #2534

nivida opened this issue Mar 20, 2019 · 0 comments
Labels
Documentation Relates to project wiki or documentation

Comments

@nivida
Copy link
Contributor

nivida commented Mar 20, 2019 •
edited
Loading

Description

The documentation for the JSON-RPC method eth_chainId on the Eth module is missing.

Edit:
Don't forget to update the types too.

Expected behavior

The Web3.js documentation does contain the method web3.eth.getChainId().

Actual behavior

The Web3.js documentation does not contain the method web3.eth.getChainId().

Steps to reproduce the behavior

  1. Check the Eth module documentation

Error Logs

Versions
@nivida nivida added the Documentation Relates to project wiki or documentation label Mar 20, 2019
@nivida nivida changed the title Document web3.eth.getChainId() Documenting web3.eth.getChainId() Mar 20, 2019
@nivida nivida mentioned this issue Apr 3, 2019
Merged
12 tasks
@nivida nivida mentioned this issue Apr 4, 2019
Merged
12 tasks
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nivida