Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sendSignedTransaction revert reason fetching #3457

Closed
cgewecke opened this issue Apr 8, 2020 · 1 comment · Fixed by #3505
Closed

Improve sendSignedTransaction revert reason fetching #3457

cgewecke opened this issue Apr 8, 2020 · 1 comment · Fixed by #3505
Assignees
@cgewecke
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
v1.2.8

Comments

@cgewecke
Copy link
Collaborator

cgewecke commented Apr 8, 2020 •
edited

RE #3420 @nivida noted in gitter that it would be better to reconstitute the failed transaction for replay as a call without making any extra server reqs. In #3420 the call params are obtained by fetching the transaction record.

An equally terse and more efficient way would be to use ethers.utils.parseTransaction.
@cgewecke cgewecke self-assigned this Apr 8, 2020
@cgewecke cgewecke added 1.x 1.0 related issues Enhancement Includes improvements or optimizations labels Apr 8, 2020
@nivida
Copy link
Contributor

nivida commented Apr 15, 2020

RLP decoding FTW ;-P @cgewecke

@cgewecke cgewecke mentioned this issue Apr 15, 2020
Merged
13 tasks
@cgewecke cgewecke added this to To do in v1.2.8 Apr 25, 2020
@muskaankalra24 muskaankalra24 mentioned this issue May 7, 2020
Merged
13 tasks
@ryanio ryanio mentioned this issue Jun 2, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgewecke cgewecke

Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
No open projects
v1.2.8
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved sendSignedTransaction revert reason fetching muskaankalra24/web3.js
2 participants
@nivida @cgewecke