Rewrite confirmTransaction to handle re-orgs

[GregTheGreek]

Problem

#3608 discovered a bug where confirmTransaction doesn't properly handle a re-org. It is most likely occurring within this code block, because there is no concept of a start/previous block theres no ability to perform a check for inconsistencies between blocks.

Potential solution

We probably want to track a few different things:

• StartBlock - When we began polling
• PreviousBlock - The block that we just checked (Note: this is not block -1, we must actually cache the received block)
• IncludedBlock - The block that the transaction was included in

This way we can do a check such as (very naive): currentBlockNumber - PrevioudBlockNumber == 1 to ensure that we're on the sequential chain. We may also want to double check that the includedBlock hasn't changed with the incoming receipt. Doing those checks could identify a reorg took place. To properly account for the number of confirmations the counter, found on line 334 should actually be computed by using currentBlockNumber - PreviousBlockNumber so it can reset if there is a re-org. I believe doing that alone, would probably solve this issue, but it might be interesting to see if we want to log a re-org.

I found an stackoverflow that can be used as inspiration.

cc: @cgewecke

[benjamincburns]

I'm writing a new TransactionManager because of #3632. If I can't fix this issue as part of the initial PR, I'll at least do my best to lay some groundwork. At the very least, the code I submit will be a lot more readable than what's there today.

[GregTheGreek]

That would be awesome!

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

[GregTheGreek]

@benjamincburns just want to confirm you're not touching on this anymore?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.