Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3.utils._ undefined #4403

Closed
1 task done
JahanzebNawaz opened this issue Sep 29, 2021 · 5 comments
Closed
1 task done

Web3.utils._ undefined #4403

JahanzebNawaz opened this issue Sep 29, 2021 · 5 comments
Labels
Bug Addressing a bug Documentation Relates to project wiki or documentation

Comments

@JahanzebNawaz
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I was testing Web3 utils and in documents Web3.utils._, it is specified about underscore library, but while testing it seems we don't have underscore library in package anymore.
Web3.utils._; returns undefined
I have gone through the utils file in the package couldn't find the underscore library imported or mentioned.

As per this issue 2282 it seems the underscore library is no more in use. changed to lodash.

Expected Behavior

As per the documents, it should be present and in working condition. if it's deprecated please update the documents.

Steps to Reproduce

Need to update documents if the library is deprecated.

Web3.js Version

1.5.3

Environment

  • Operating System: Ubuntu 21.04
  • Browser: Firefox Browser 92.0 (64bit).
  • Node.js Version: v12.21.0
  • NPM Version: 7.20.5

Anything Else?

No response

@JahanzebNawaz JahanzebNawaz added the Bug Addressing a bug label Sep 29, 2021
@luu-alex
Copy link
Contributor

We removed the underscore package recently and web3.utils._ should be removed from the docs, thank you for pointing this out :)

@spacesailor24 spacesailor24 added the Documentation Relates to project wiki or documentation label Sep 30, 2021
@JahanzebNawaz
Copy link
Author

Thanks, @luu-alex for the confirmation.

@JahanzebNawaz
Copy link
Author

@luu-alex I updated the docs and tried to push but it seems I need to get permission first? is there any way to get permission I want to be part of the community?
Thanks

@nazarhussain
Copy link
Contributor

@JahanzebNawaz You have to fork the repo and then make changes to it and create a pull request agains the our repo. For further details you can can check this link. You should also look our contribution guide for more details.

@JahanzebNawaz
Copy link
Author

Thanks, @nazarhussain

JahanzebNawaz added a commit to JahanzebNawaz/web3.js that referenced this issue Oct 2, 2021
spacesailor24 pushed a commit that referenced this issue Oct 8, 2021
Test aren't going to run since it's only a doc change

* Utils _ (underscore lib) context removed  #4403

* changelog updated for #4403
@spacesailor24 spacesailor24 mentioned this issue Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug Documentation Relates to project wiki or documentation
Projects
None yet
Development

No branches or pull requests

4 participants