Feature/es6 first tests #1152
Merged
Feature/es6 first tests #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started by converting HttpProvider to es6, which led to the conversion of contract.js, eth.sendTransaction.js, and setProvider.js Enabling ES6 support in Mocha led to fixes in method.buildCall.js and utils.sha3.js Fixed the problems in test/eth.sendTransaction.js that were causing the error "Transaction was not mined within 50 blocks, please make sure your transaction was properly send. Be aware that it might still be mined!". There may be deeper issues with the tests in eth.sendTransaction.js, these will require some conversation with Fabian before moving forward.
1 similar comment
|
I've browsed through the differences in coverage, and it appears to be entirely related to the change from istanbul 0.4.5 to nyc 11.2.1 (the new istanbul) |
|
i merged the first PR, can you please resolve the conflicts this one has now? |
…ture/es6-firstTests # Conflicts: # .eslintrc # .gitignore # .travis.yml # README.md # gulp/config.js # gulp/transpile.js # package.json # test/.eslintrc # test/eth.sendTransaction.js
|
Changes Unknown when pulling 1419c40 on blitzpredict:feature/es6-firstTests into ** on ethereum:1.0ES6**. |
|
Changes Unknown when pulling d6fe282 on blitzpredict:feature/es6-firstTests into ** on ethereum:1.0ES6**. |
…ture/es6-firstTests # Conflicts: # test/eth.sendTransaction.js
frozeman
approved these changes
Nov 27, 2017
|
Sorry for the late review, but I’m quite busy these days. Looks good and thanks for all that effort! |
frozeman
pushed a commit
that referenced
this pull request
Apr 19, 2018
* First draft of babel+eslint+rollup * Moved to gulp 4, improved some logging output during builds. * Tweaks to the build process. * Fixing the versioning task. * Created separate copies of the .eslintrc files, one for each package. * Started converting the first of the tests to es6. Started by converting HttpProvider to es6, which led to the conversion of contract.js, eth.sendTransaction.js, and setProvider.js Enabling ES6 support in Mocha led to fixes in method.buildCall.js and utils.sha3.js Fixed the problems in test/eth.sendTransaction.js that were causing the error "Transaction was not mined within 50 blocks, please make sure your transaction was properly send. Be aware that it might still be mined!". There may be deeper issues with the tests in eth.sendTransaction.js, these will require some conversation with Fabian before moving forward. * Fixing coverage problems by upgrading to nyc (the new istanbul) * Fixed test failure on node 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based upon "Step 1 of moving to ES6" (#1149). The changes should consist of only 11 files, once that change is merged.
Started converting the first of the tests to es6.
Started by converting HttpProvider to es6, which led to the conversion of contract.js, eth.sendTransaction.js, and setProvider.js
Enabling ES6 support in Mocha led to fixes in method.buildCall.js and utils.sha3.js
Fixed the problems in test/eth.sendTransaction.js that were causing the error "Transaction was not mined within 50 blocks, please make sure your transaction was properly send. Be aware that it might still be mined!".
There may be deeper issues with the tests in eth.sendTransaction.js, these will require some conversation with Fabian before moving forward.