Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1089 #1162

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Fix #1089 #1162

merged 1 commit into from
Nov 13, 2017

Conversation

jdkanani
Copy link
Contributor

@jdkanani jdkanani commented Nov 9, 2017

No description provided.

@coveralls
Copy link

coveralls commented Nov 9, 2017 •
edited

Coverage Status

Coverage remained the same at 85.566% when pulling 085a296 on jdkanani:patch-2 into edd801b on ethereum:1.0.

@frozeman frozeman merged commit 15ffd55 into web3:1.0 Nov 13, 2017
@frozeman
Copy link
Contributor

Thanks for that @jdkanani

@jdkanani jdkanani deleted the patch-2 branch November 13, 2017 11:10
@lionello
Copy link
Contributor

Hey, this broke my test. "0x" is not a valid uint256, so not happy with this being handled in this low-level conversion code.

nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@jdkanani @nachomazzara
Fix web3#1089 (web3#1162)
6f3ba5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frozeman frozeman frozeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdkanani @coveralls @frozeman @lionello