Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty string handling for asciiToHex #1196

Merged
merged 1 commit into from
Nov 27, 2017
Merged

empty string handling for asciiToHex #1196

merged 1 commit into from
Nov 27, 2017

Conversation

vibhumbhardwaj
Copy link
Contributor

Will return 0x00 for empty inputs.

0x was giving me inconsistent results while sending the contract deploy (if multiple 0x arguments in array). So, I used 0x00.

@coveralls
Copy link

coveralls commented Nov 23, 2017

Coverage Status

Coverage decreased (-0.03%) to 85.561% when pulling 27f8f62 on vibhumbhardwaj:1.0 into d19f889 on ethereum:1.0.

@frozeman frozeman merged commit 74748a3 into web3:1.0 Nov 27, 2017
@frozeman
Copy link
Contributor

Good point. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants