Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS refactored #1855

Merged
merged 14 commits into from
Aug 14, 2018
Merged

ENS refactored #1855

merged 14 commits into from
Aug 14, 2018

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Aug 8, 2018

No description provided.

@nivida
Copy link
Contributor Author

nivida commented Aug 8, 2018

Depends on: #1848

@coveralls
Copy link

coveralls commented Aug 9, 2018

Coverage Status

Coverage decreased (-0.6%) to 83.353% when pulling 102c88b on ens-refactoring into b1e0552 on 1.0.

@frozeman frozeman merged commit 821cca3 into 1.0 Aug 14, 2018
@nivida nivida deleted the ens-refactoring branch August 17, 2018 13:45
@nivida nivida mentioned this pull request Nov 20, 2019
11 tasks
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
* ENS refactored

* ResolverMethodHandler improved

* console.log removed, codestyle improved

* unshift fixed

* parent added to binding in ResolverMethodHandler

* handleSend and handleCall fixed in ResolverMethodHandler

* Tests updated and ENS fixed

* sendOptions added to handleSend method

* package.json versions fixed

* PromiEvent added to package.json

* ENS fixes and resolver method added to ENS Object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants