Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebsocketProvider improvements #2855

Merged
merged 14 commits into from
Jun 4, 2019
Merged

WebsocketProvider improvements #2855

merged 14 commits into from
Jun 4, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented May 29, 2019

Description

Fixes #2711 #2851

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels May 29, 2019
Copy link

@boomfly boomfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbstractSocketProvider.js 169 line:
this.removeAllListeners();
this line removes all app defined provider listeners, so we can't receive 'connect', 'reconnected', 'error' events any more

Copy link

@boomfly boomfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed import isFunction in AbstractSubscription so on line 167, 180 undefined exception

@boomfly
Copy link

boomfly commented May 30, 2019

All other seems fine. I hope this PR merged. I need it very much

@nivida
Copy link
Contributor Author

nivida commented May 31, 2019

@boomfly Yes, I'll fix all of these. I'm currently testing the reconnecting of the socket connection with different edge cases etc. I will tag you for a final review later:)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.743% when pulling c8ba201 on fix/websocket-reconnecting into c3f4845 on 1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 95.743% when pulling c8ba201 on fix/websocket-reconnecting into c3f4845 on 1.0.

@coveralls
Copy link

coveralls commented Jun 4, 2019

Coverage Status

Coverage decreased (-0.1%) to 95.743% when pulling c8ba201 on fix/websocket-reconnecting into c3f4845 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Jun 4, 2019
@nivida nivida merged commit ef84067 into 1.0 Jun 4, 2019
@nivida nivida deleted the fix/websocket-reconnecting branch June 11, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebsocketProvider event emitter problem
3 participants