Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 1.2.4 #3214

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Release - 1.2.4 #3214

merged 2 commits into from
Nov 15, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 15, 2019 •
edited

Description

Fixed

Compare View

v1.2.3 -> v1.2.4

Type of change

  • Release

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@nivida nivida added In Progress Currently being worked on Release 1.x 1.0 related issues labels Nov 15, 2019
@nivida nivida requested a review from cgewecke November 15, 2019 09:39
cgewecke
cgewecke approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivida nivida removed the In Progress Currently being worked on label Nov 15, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.347% when pulling 341015a on release/1.2.4 into e252b8c on 1.x.

@nivida nivida merged commit 5c78c2b into 1.x Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nivida @coveralls @cgewecke