Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

big-number (BN & BigNumber) mapping added to abi.encodeParameters #3238

Merged
merged 3 commits into from
Nov 26, 2019
Merged

big-number (BN & BigNumber) mapping added to abi.encodeParameters #3238

merged 3 commits into from
Nov 26, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 25, 2019 •
edited

Description

Fixes #3221 #2077

This PR allows passing BN or BigNumber objects to the encodeParameter and encodeParameters method of the AbiCoder.

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Enhancement Includes improvements or optimizations 1.x 1.0 related issues labels Nov 25, 2019
@nivida nivida requested a review from cgewecke November 25, 2019 11:30
@coveralls
Copy link

coveralls commented Nov 25, 2019 •
edited

Coverage Status

Coverage increased (+0.02%) to 84.485% when pulling 20103ba on issue/3221 into 3404e20 on 1.x.

cgewecke
cgewecke approved these changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nivida nivida merged commit e914ec3 into 1.x Nov 26, 2019
@nivida nivida deleted the issue/3221 branch November 26, 2019 15:25
@nivida nivida mentioned this pull request Jan 16, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web3.eth.abi.encodeParameters breaks for BN
3 participants
@nivida @coveralls @cgewecke