Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends the web3-eth module with the method getPendingTransactions #3239

Merged
merged 4 commits into from
Nov 26, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 25, 2019

Description

This PR does add the JSON-RPC method eth_pendingTransactions as getPendingTransactions method to the web3-eth module.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Feature Request 1.x 1.0 related issues labels Nov 25, 2019
@nivida nivida marked this pull request as ready for review November 25, 2019 11:52
@nivida nivida requested a review from cgewecke November 25, 2019 11:52
@coveralls
Copy link

coveralls commented Nov 25, 2019

Coverage Status

Coverage remained the same at 84.467% when pulling a0efc21 on feature/getPendingTransactions into 335e8e6 on 1.x.

Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. The types are already defined here...everything looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants