Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to increase coverage #3452

Closed
wants to merge 3 commits into from
Closed

Conversation

linababenko
Copy link

@linababenko linababenko commented Apr 2, 2020

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Apr 2, 2020

Coverage Status

Coverage increased (+0.3%) to 90.591% when pulling 2ecb6aa on linababenko:add_tests into 6862c59 on ethereum:1.x.

@ryanio
Copy link
Collaborator

ryanio commented Apr 8, 2020

Hey @linababenko, thanks for your contributions!

Just wondering, how did you decide to add these tests in particular? If you check out Coveralls you can see some more info about the library source files and which lines are or aren't covered by the current test suite.

@ryanio ryanio added 1.x 1.0 related issues Testing labels Apr 10, 2020
@ryanio ryanio changed the title Added tests for to increase the percentage of coverage Add tests to increase coverage Jun 2, 2020
@ryanio ryanio mentioned this pull request Jun 2, 2020
13 tasks
@GregTheGreek
Copy link
Contributor

@linababenko I'd love to get this merged in, could you ensure your branch is up-to-date?

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Aug 13, 2020
@GregTheGreek GregTheGreek removed the Stale Has not received enough activity label Aug 13, 2020
@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Oct 13, 2020
@cokia
Copy link
Contributor

cokia commented Oct 19, 2020

I think this is a good test case addition PR, and I don't think it should be kept stale!

@GregTheGreek GregTheGreek removed the Stale Has not received enough activity label Oct 19, 2020
@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Dec 19, 2020
@github-actions github-actions bot closed this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants